Merged
Conversation
Contributor
|
There are two more references in SubscriptionsImportService. However, I am not sure if we should change that. tobias@tobias-mint-3:~/Dokumente/NewPipe/NewPipe/app/src/main/java$ grep -irn '"org.schabi.newpipe'
org/schabi/newpipe/local/subscription/services/SubscriptionsImportService.java:69: public static final String IMPORT_COMPLETE_ACTION = "org.schabi.newpipe.local.subscription"
org/schabi/newpipe/local/subscription/services/SubscriptionsExportService.java:53: public static final String EXPORT_COMPLETE_ACTION = "org.schabi.newpipe.local.subscription"
org/schabi/newpipe/local/feed/service/FeedLoadService.kt:70: private const val ACTION_CANCEL = "org.schabi.newpipe.local.feed.service.FeedLoadService.CANCEL"
org/schabi/newpipe/player/MainPlayer.java:67: = "org.schabi.newpipe.player.MainPlayer.CLOSE";
org/schabi/newpipe/player/MainPlayer.java:69: = "org.schabi.newpipe.player.MainPlayer.PLAY_PAUSE";
org/schabi/newpipe/player/MainPlayer.java:71: = "org.schabi.newpipe.player.MainPlayer.OPEN_CONTROLS";
org/schabi/newpipe/player/MainPlayer.java:73: = "org.schabi.newpipe.player.MainPlayer.REPEAT";
org/schabi/newpipe/player/MainPlayer.java:75: = "org.schabi.newpipe.player.MainPlayer.ACTION_PLAY_NEXT";
org/schabi/newpipe/player/MainPlayer.java:77: = "org.schabi.newpipe.player.MainPlayer.ACTION_PLAY_PREVIOUS";
org/schabi/newpipe/player/MainPlayer.java:79: = "org.schabi.newpipe.player.MainPlayer.ACTION_FAST_REWIND";
org/schabi/newpipe/player/MainPlayer.java:81: = "org.schabi.newpipe.player.MainPlayer.ACTION_FAST_FORWARD";
org/schabi/newpipe/player/MainPlayer.java:83: = "org.schabi.newpipe.player.MainPlayer.ACTION_SHUFFLE";
org/schabi/newpipe/player/MainPlayer.java:85: = "org.schabi.newpipe.player.MainPlayer.ACTION_RECREATE_NOTIFICATION";
org/schabi/newpipe/fragments/detail/VideoDetailFragment.java:148: "org.schabi.newpipe.VideoDetailFragment.ACTION_SHOW_MAIN_PLAYER";
org/schabi/newpipe/fragments/detail/VideoDetailFragment.java:150: "org.schabi.newpipe.VideoDetailFragment.ACTION_HIDE_MAIN_PLAYER";
org/schabi/newpipe/fragments/detail/VideoDetailFragment.java:152: "org.schabi.newpipe.VideoDetailFragment.ACTION_PLAYER_STARTED";
org/schabi/newpipe/fragments/detail/VideoDetailFragment.java:154: "org.schabi.newpipe.VideoDetailFragment.ACTION_VIDEO_FRAGMENT_RESUMED";
org/schabi/newpipe/fragments/detail/VideoDetailFragment.java:156: "org.schabi.newpipe.VideoDetailFragment.ACTION_VIDEO_FRAGMENT_STOPPED";Code looks good to me. I didn't test the changes yet. |
Member
Author
|
fixed in the last commit |
B0pol
added
bug
it fixes issues with forks or debug builds, e.g. when you open two newpipe apps (with debug or fork apps), close one notification, it closes all newpipe notifications fixes TeamNewPipe#4653
Stypox
approved these changes
Jan 1, 2021
Collaborator
|
Yay! |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
org.schabi.newpipeFixes the following issue(s)
APK testing
Due diligence